> @@ -526,16 +592,19 @@ int inet_connect(const char *str, Error **errp) > return sock; > } > > - > -int inet_nonblocking_connect(const char *str, bool *in_progress, > - Error **errp) > +int inet_nonblocking_connect(const char *str, ConnectHandler *callback, > + void *opaque, bool *in_progress, Error **errp) > {
Would be nice to have some documentation here. Something like "on immediate success or immediate failure, in_progress is set to false, in that case callback is not invoked". If you look at it this way, this API is hard to use right. I'd like to suggest we get rid of in_progress flag: return -1 on error and return >=0 and invoke callback on immediate success. -- MST