Thanks, Paul. The attached updated patch seems to fix this bug. Comments? -----Original Message----- From: Paul Brook [mailto:[EMAIL PROTECTED] Sent: Monday, October 22, 2007 1:53 PM To: qemu-devel@nongnu.org Cc: Arnon Gilboa Subject: Re: [Qemu-devel] [PATCH, RFC] USB OHCI isochronous transfers support
On Monday 22 October 2007, Arnon Gilboa wrote:
> Hi,
>
> The attached patch adds isochronous transfers support to the OHCI
> emulation, similarly to the UHCI patch pushed two weeks ago.
> + uint16_t offset[8];
> +};
> +static inline int ohci_read_iso_td(uint32_t addr, struct ohci_iso_td
> +*td) {
> + return get_dwords(addr, (uint32_t *)td, sizeof(*td) >> 2); }
This is wrong. It will break on big-endian hosts.
set_dwords only DTRT if all the structure fields are 32-bit.
Paul
usb-ohci-iso.patch
Description: usb-ohci-iso.patch
