On 09/21/2012 11:07 AM, Luiz Capitulino wrote: > fd_write_vmcore() will indefinitely spin for a non-blocking > file-descriptor that would block. However, if the fd is non-blocking, > how does it make sense to spin? > > Change this behavior to return an error instead. > > Note that this can only happen with an fd provided by a management > application. The fd opened internally by dump-guest-memory is blocking. > > Signed-off-by: Luiz Capitulino <lcapitul...@redhat.com> > --- > dump.c | 13 +++---------- > 1 file changed, 3 insertions(+), 10 deletions(-) > > diff --git a/dump.c b/dump.c > index 2bf8d8d..5eea015 100644 > --- a/dump.c > +++ b/dump.c > @@ -100,18 +100,11 @@ static void dump_error(DumpState *s, const char *reason) > static int fd_write_vmcore(void *buf, size_t size, void *opaque) > { > DumpState *s = opaque; > - int fd = s->fd; > size_t writen_size;
While you are here, s/writen/written/ in the local variable. -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature