On 09/25/2012 12:58 PM, Jeff Cody wrote: > On 09/25/2012 02:12 PM, Eric Blake wrote: >> On 09/25/2012 10:29 AM, Jeff Cody wrote: >>> This adds the live commit coroutine. This iteration focuses on the >>> commit only below the active layer, and not the active layer itself. >>>
>> I think you are missing a check here that base is on the backing chain >> of top. See also my comments to 5/7. >> > > Did you mean your comments on 6/7 (or am I missing an email)? Shoot. You're right, and I messed myself up by reviewing out of order :) > > This does get partially validated in patch 5/7, in the > qmp_block_commit() handler - both base and top are verified to be in the > chain 'bs'. What is not validated, however, is that you did not swap > your 'top' and 'base' arguments. I'll add a check here for that, to > make sure that base is reachable from overlay_bs. At any rate, it sounds like I got my point across, in spite of myself. -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
