On 09/26/2012 09:56 AM, Paolo Bonzini wrote: > Even for jobs that need to be manually completed, management may want > to take care itself of the completion, not requiring the user to issue > a command to terminate the job. In this case we want to avoid that > they poll us continuously, waiting for completion to become available. > Thus, add a new event that signals the phase switch and the availability > of the block-job-complete command. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > ---
>
> +BLOCK_JOB_READY
> +---------------
> +
> +Emitted when a block job is ready to complete.
> +
> +Data:
> +
> +- "device": device name (json-string)
> +
> +Example:
> +
> +{ "event": "BLOCK_JOB_READY",
> + "data": { "device": "ide0-hd1",
> + "operation": "write",
> + "action": "stop" },
You didn't document operation and action; are you missing documentation
for this event, or are they bad copy-and-paste in the example?
Again, libvirt would really like to have 'type':'mirror' in the data,
for symmetry with all the other BLOCK_JOB_* events.
--
Eric Blake ebl...@redhat.com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
