On 09/27/2012 01:57 PM, Eric Blake wrote: > On 09/27/2012 11:29 AM, Jeff Cody wrote: >> The command for live block commit is added, which has the following >> arguments: >> >> device: the block device to perform the commit on (mandatory) >> base: the base image to commit into; optional (if not specified, >> it is the underlying original image) >> top: the top image of the commit - all data from inside top down >> to base will be committed into base (mandatory for now; see >> note, below) >> > >> +++ b/qmp-commands.hx >> @@ -792,6 +792,12 @@ EQMP >> }, >> >> { >> + .name = "block-commit", >> + .args_type = "device:B,base:s?,top:s?,speed:o?", > > s/top:s?/top:s/ now that top is mandatory. >
Right, forgot the hx file. Although, QAPI catches it just fine regardless of the hx file... but I will spin that really quick (hopefully that is the only change required), unless Kevin wants to do it when he pulls it into his branch.