>> +const uint64_t *qb_get_virt_size(const QBlockStaticInfo *info) >> +{ >> + return info->member_addr->virt_size; > >Please change this to: > > QBlockStaticInfoAddr addrs; > qb_setup_info_addr(info, &addrs); > return *addrs->virt_size; > >and similarly for the others. > >QBlockStaticInfoAddr should not be a public struct. I'm sorry if this >wasn't clear. > >I'll review the rest on Monday. > >Paolo > Hi, QBlockStaticInfoAddr was declared as a pointer, user can't see what it really is. It is actually defined in internal header files.
- [Qemu-devel] [PATCH V5 0/5] libqblock qemu block layer libra... Wenchao Xia
- [Qemu-devel] [PATCH V5 4/5] libqblock test build system Wenchao Xia
- [Qemu-devel] [PATCH V5 5/5] libqblock test example Wenchao Xia
- Re: [Qemu-devel] [PATCH V5 5/5] libqblock test exam... wenchao xia
- Re: [Qemu-devel] [PATCH V5 5/5] libqblock test ... Paolo Bonzini
- Re: [Qemu-devel] [PATCH V5 5/5] libqblock t... wenchao xia
- Re: [Qemu-devel] [PATCH V5 5/5] libqbl... Paolo Bonzini
- [Qemu-devel] [PATCH V5 3/5] libqblock API Wenchao Xia
- Re: [Qemu-devel] [PATCH V5 3/5] libqblock API Paolo Bonzini
- [Qemu-devel] [PATCH V5 2/5] libqblock type defines Wenchao Xia
- [Qemu-devel] [PATCH V5 1/5] libqblock build system Wenchao Xia