On 10/04/2012 09:22 AM, Peter Maydell wrote:
> Update the -help output and documentation so that it recommends
> 'help' rather than '?' for the various "list valid values for this
> option" cases. '?' is deprecated (as it can fail confusingly if
> not quoted), so it's better to steer users towards 'help'. ('?'
> still works, for backwards compatibility.)
>
> This is the -help option part of the change otherwise done in
> commit c8057f9, since we are now past release 1.2 and free to
> change our help text without worrying about breaking libvirt.
>
> Signed-off-by: Peter Maydell <peter.mayd...@linaro.org>
> ---
> v1->v2: added quoting to '-foo help' in various places
> (I don't entirely agree with Eric about this but it will
> probably help to unblock this patch)I wasn't entirely opposed to your proposed v1 approach of minimal diff, and saving formatting for a separate patch; but now that you've done the work, v2 is also nice and relatively easy to follow. Yes, I also hope this unblocks the patch. > > NB: v1 of this patch got a: > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > but I'm guessing you meant that to be a Reviewed-by or Acked-by ? Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
