Paolo Bonzini <pbonz...@redhat.com> writes: > Il 05/10/2012 14:43, Jan Kiszka ha scritto: >>>> >> This "| 1" might be the problem. Anthony, are you relying on it in >>>> >> qemu-test and/or can you work out the changes if we use just >>>> >> "exit(val)"? >>> > >>> > The reason for ' | 1' was to make sure that the guest couldn't trigger >>> > an exit(0). >>> > >>> > If there's a compelling reason to drop '| 1', I can adjust my tests >>> > accordingly. >> assert(val); (or hw_error) >> exit(val); >> >> I would suggest. > > I think what the kvm_unittests want is exactly to trigger an exit(0). > Why did you rule it out?
Mainly to differientiate between an open coded exit(0)/exit(1) and something triggered by the unit test. The problem I tried to cope with was: anthony@titi:~/git/qemu$ grep 'exit([01])' hw/*.c | wc -l 249 Regards, Anthony Liguori > > Paolo
