Paolo Bonzini <pbonz...@redhat.com> writes: > Nice cleanup, thanks! > > As a followup, there is some confusion between values of the revision > property (1-4) and PCI device revisions (QXL_REVISION_STABLE_Vxy). They > are the same right now, but this means that you can do one of the following: > > 1) if they are always going to be the same, eliminate pci_device_rev > from qxl_init_common, just use qxl->revision instead; > > 2) if they might diverge, change the value of QXL_DEFAULT_REVISION from > QXL_REVISION_STABLE_V12 to 4.
Without knowing why these names are separate, it's difficult to say whether (1) or (2) is right. In any case, it seems like an orthogonal issue from the revision bump itself. Søren
