On Fri, Oct 05, 2012 at 04:24:08PM +0000, Blue Swirl wrote: > Endianness looks buggy, there's no way to turn off big endian mode
I double checked the documentation and I think you're right, I can update the patch. Thanks for pointing it out. > DEVICE_NATIVE_ENDIAN should probably be DEVICE_LITTLE_ENDIAN. Where? In BAR0? > Indentation of braces in switch cases looks strange. I tried to follow the CODING_STYLE file, but I might have got it wrong, I can change that. > Pointers to HW documentation and description how to test (or qtests) > would be nice. The documentation is available online: http://www.tews.com/Products/ArticleGroup/TPCI/TPCI200.html http://www.mvme.com/manuals/IP-OCTAL-232_UM.pdf http://www.alldatasheet.com/datasheet-pdf/pdf/19123/PHILIPS/SCC2698B.html I'm not familiar with qtests, should I take a look at it? In my blog post (see previous e-mail) there's a brief explanation on how to test it. I can provide with a compiled Linux kernel with the necessary drivers for the guest system if it helps. A quick way to test it is to redirect one of the IP-Octal serial ports to a pty in the host and open minicom in both sides. > I'd suppose addressing devices in the bus could be implemented > more efficiently with better use of memory API, now some of it is > reimplemented. Maybe Avi can propose something? I'm open to suggestions. And answering Andreas, yes, the device could be renamed as 'ipoctal232' :) Thanks, Berto