On 10/09/2012 08:13 AM, Aurelien Jarno wrote: >> > It also prefers >> > >> > add r, r, c >> > over >> > add r, c, r >> > >> > when both inputs are known constants. This doesn't matter for true add, as >> > we will fully constant fold that. But it matters for a follow-on patch >> > using >> > this routine for add2 which may not be fully foldable. ... > Does this sum += and -= actually generates better code than the previous > one? It's not something obvious to read (fortunately there is the > comment for helping), so if it doesn't bring any optimization, it's > better to keep the previous form.
Yes. See the comment within the log above. r~