Il 11/10/2012 23:26, Luiz Capitulino ha scritto: > I'm calling this an RFC because I did it on hurry and it's almost untested, > but I wanted to drop it for early review while I'm out for a public holiday :) > > This should improve qmp_transaction() error messages on bdrv_img_create() > failure quite a bit. Also, the "formatting" message is not printed to stdout > anymore when in QMP. > > Luiz Capitulino (6): > block: bdrv_img_create(): add param_ret argument > block: bdrv_img_create(): move param printing to qemu-img > block: bdrv_img_create(): add Error ** argument > qemu-img: img_create(): use Error object > qmp: qmp_transaction(): pass Error object to bdrv_img_create() > block: bdrv_img_create(): drop unused code > > Paolo Bonzini (1): > error: add error_set_errno and error_setg_errno > > block.c | 69 > +++++++++++++++++++++++++++----------------------------------- > block.h | 7 ++++--- > blockdev.c | 13 ++++++------ > error.c | 28 +++++++++++++++++++++++++ > error.h | 9 ++++++++ > qemu-img.c | 18 +++++++++++++--- > 6 files changed, 93 insertions(+), 51 deletions(-) >
Looks good. We could debate endlessly how to order the patches, but the idea is fine. Paolo
