Il 12/10/2012 14:39, Gerd Hoffmann ha scritto: > + chr = qemu_chr_new_from_opts(opts, NULL); > + if (chr == NULL) { > + qemu_opts_del(opts); > + error_setg(&err, "Creating chardev failed\n"); > + goto exit_err; > + } > + return 0; > +
Since you have to do a v3, please make this part (which is common between HMP and QMP) a separate function. Paolo