On 10/12/2012 04:36 AM, Benjamin Herrenschmidt wrote: > On Thu, 2012-10-11 at 15:26 +0200, Avi Kivity wrote: >> These patches add IOMMU support to the memory core. IOMMUs can be added >> anywhere in >> the memory hierarchy, and may be arranged in series. > > I haven't had a chance to review in details yet, but one thing I noticed > is that you basically have a single read/write protection information > for a translation. > > This is a loss of functionality to some extent (well, maybe not from the > existing iommu layer but from what could be done by our HW) in that we > have separate read and write permission bits. > > This is actually worth fixing I think. Catching incorrect reads from > write-only regions is probably worth it in term of debugging drivers. >
I do have an is_write parameter to translate, in fact I added it in order to implement the spapr iommu. Or do you mean something else? -- error compiling committee.c: too many arguments to function
