On 10/18/2012 08:49 AM, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > v2->v3: unit of measure is now bytes > > block.c | 7 +++++++ > qapi-schema.json | 20 ++++++++++++++++++-- > 2 file modificati, 25 inserzioni(+), 2 rimozioni(-) > > +++ b/qapi-schema.json > @@ -629,7 +629,7 @@ > '*backing_file': 'str', 'backing_file_depth': 'int', > 'encrypted': 'bool', 'encryption_key_missing': 'bool', > 'bps': 'int', 'bps_rd': 'int', 'bps_wr': 'int', > - 'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int'} } > + 'iops': 'int', 'iops_rd': 'int', 'iops_wr': 'int' } } >
This whitespace change hunk looks out of place... > ## > # @BlockDeviceIoStatus: > @@ -647,6 +647,18 @@ > { 'enum': 'BlockDeviceIoStatus', 'data': [ 'ok', 'failed', 'nospace' ] } > > ## > +# @BlockDirtyInfo: > +# > +# Block dirty bitmap information. > +# > +# @count: number of dirty bytes according to the dirty bitmap > +# > +# Since: 1.3 > +## > +{ 'type': 'BlockDirtyInfo', > + 'data': {'count': 'int'} } ...especially since you aren't consistent on using space before } However, I can live with it, rather than needing a v4. -- Eric Blake ebl...@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature