On Thu, Oct 18, 2012 at 1:11 PM, Peter Maydell <peter.mayd...@linaro.org> wrote: > This patch series introduces a new logging category to > qemu_log_mask(), for reporting situations which the device > model can cope with but which indicate bugs in the guest. > The most common cause of these is "guest tried to access > a register which doesn't exist". At the moment device models > use an inconsistent mix of "silently ignore", "hw_error(), > killing qemu" and "direct print to stderr" for reporting > this kind of event. > > Patches 3-8 are a random selection of ARM devices which I've > switched to using the new LOG_GUEST_ERROR (or the existing > LOG_UNIMP where that is more appropriate). There are obviously > more conversions that could be made; this is just a sample > to demonstrate the utility of the log category. > > Changes v1->v2: > * add patch 2 including qemu-log.h in hw/hw.h > * update 3..8 to not include qemu-log.h directly
Thanks, applied all. > > Peter Maydell (8): > qemu-log: Add new log category for guest bugs > hw/hw.h: Add include of qemu-log.h > hw/pl181: Use LOG_UNIMP and LOG_GUEST_ERROR > hw/pl041: Use LOG_UNIMP > hw/pl190: Use LOG_GUEST_ERROR > hw/pl011: Use LOG_UNIMP and LOG_GUEST_ERROR > hw/pl022: Use LOG_UNIMP and LOG_GUEST_ERROR > hw/pl031: Use LOG_GUEST_ERROR > > hw/hw.h | 1 + > hw/pl011.c | 11 +++++++---- > hw/pl022.c | 8 +++++--- > hw/pl031.c | 16 ++++++++++------ > hw/pl041.c | 5 +++-- > hw/pl181.c | 18 ++++++++++-------- > hw/pl190.c | 6 ++++-- > qemu-log.c | 3 +++ > qemu-log.h | 1 + > 9 files changed, 44 insertions(+), 25 deletions(-) > > -- > 1.7.9.5 > >