On 23 October 2012 08:03, Gerd Hoffmann <kra...@redhat.com> wrote: > On 10/22/12 15:51, Peter Maydell wrote: >> On 22 October 2012 14:28, Gerd Hoffmann <kra...@redhat.com> wrote: >>> Commit 585f60368f23e6603cf86cfdaeceb89d1169f4b8 appearently breaks the >>> libvirt feature detection, my guests fail to start with this message: >>> >>> error: Failed to start domain fedora-org-virtio >>> error: internal error qemu does not support SGA >>> >>> Running libvirt-0.10.2-2.el6.x86_64 >> >> Yeah, this is the commit that means you need an updated libvirt >> from this point on (and in particular for qemu-1.3). > > Well, only problem is that 0.10.2 already is the latest libvirt release. > Was it really intentional to break things like this?
This change was postponed to after 1.2 was released to give libvirt a chance to wean itself off parsing our --help output. I took Eric's Reviewed-by as an indication he was happy with it going in now from the libvirt side... -- PMM