On Sun, Nov 11, 2007 at 05:24:06PM +0000, Paul Brook wrote: > > +#undef NULL > > +#define NULL ((void *)0) > > Absolutely not.
this was not meant to be a final solution, or even be committed in qemu, just a stop gap solution answering Ben so that he can get their build to complete and have a somehow equivalent definition of what the code is doing in linux (where I presume was tested) until it can be fixed in a portable way. Ben's solution was to replace _INTC_ARRAY(NULL) with "NULL, NULL" but it should had been instead "NULL, 4" or "NULL, 8" depending on what ISA he is compiling it for, doing the "#undef/#define" leads to that and, yes I agree it is awful. Carlo
