On 24 October 2012 09:42, Markus Armbruster <arm...@redhat.com> wrote: > Peter Maydell <peter.mayd...@linaro.org> writes: > >> A lot of the ARM board models follow the pattern of having a >> single common init function which is called with various >> parameters from the QEMUMachine init function for several board >> model variants. The change to QEMUMachineInitArgs in commit 5f072e >> took the fairly mechanical approach of splitting the QEMUMachineInitArgs >> fields out in each variant's init function to pass to an unchanged >> common init function. This is a bit repetitive, so clean them up >> to just pass the QEMUMachineInitArgs directly to the common >> function instead. > > A quick grep finds similar cleanup opportunities in > > hw/exynos4_boards.c exynos4_boards_init_common() > hw/pc_piix.c pc_init1() > hw/sun4m.c sun4m_hw_init() > hw/sun4u.c sun4uv_init() > hw/xtensa_lx60.c lx_init() > hw/xtensa_sim.c sim_init()
I deliberately stuck to the ARM boards on the basis that the others were a little out of my jurisdiction. I missed the exynos4 though. -- PMM
