Paolo Bonzini <pbonz...@redhat.com> writes: > Il 26/10/2012 13:01, Amit Shah ha scritto: >> Amit Shah (1): >> virtio-rng: hardware random number generator device >> >> Anthony Liguori (7): >> object: add object_property_add_bool (v2) >> qdev: add realized property and make adding child bus implied by >> realize >> vl: add -object option to create QOM objects from the command line >> vl: add -late-object to create QOM objects after machine init >> rng: add RndBackend abstract object class >> rng-urandom: add an RNG backend that uses /dev/urandom >> rng-egd: introduce EGD compliant RNG backend > > Honestly I think this is overengineered. > > I would instead have the following: > > - a chardev that can read from a file (e.g. -chardev > file,path=/dev/urandom,read=on,id=urandom)
Then your multiplexing lots of logic into the chardev layer. Three of these patches can be dropped. See the series I sent out. Regards, Anthony Liguori > - a device that accepts a chardev and understands both egd and raw > (e.g. > -device virtio-rng-pci,chardev=urandom,egd=off or -device > virtio-rng-pci,chardev=egdsock,egd=on). > > - optionally, a chardev that can produce an endless stream of data via > rdrand. > > And that's it. > > Also, even if RngBackend goes in, there is no need for -late-object > right now, so I would not include it in this series. > > Paolo