This patch series cleans up the m68k semihosting support to not ignore failure of get_user and put_user when reading semihosting arguments and writing return values (compare f296c0d1 which did something similar for ARM semihosting). The main motivation for this patch is to shut up clang's complaints about 'expression result unused'. Tested with a simple m68k hello world semihosting binary created with the CodeSourcery coldfire toolchain: ~/freescale-coldfire-2011.09/bin/m68k-elf-gcc -T m5206ec3-ram-hosted.ld -o /tmp/hello /tmp/hello.c -lc -lcs3hosted ./m68k-softmmu/qemu-system-m68k -semihosting -M dummy -display none -kernel /tmp/hello
Meador's patch is already in qemu-trivial but I include it here as it is a dependency. Meador Inge (1): m68k: Return semihosting errno values correctly Peter Maydell (2): target-m68k/m68k-semi: Handle get_user failure target-m68k/m68k-semi.c: Log when put_user for returning values fails target-m68k/m68k-semi.c | 191 +++++++++++++++++++++++++++++++----------------- 1 file changed, 124 insertions(+), 67 deletions(-) -- 1.7.11.4