On 11/01/2012 05:42 PM, Stefan Hajnoczi wrote:
On Thu, Nov 1, 2012 at 8:48 AM, Lei Li <li...@linux.vnet.ibm.com> wrote:
netdev_del assume that remove host network device.
However, when try to remove a non-host network device
by netdev_del, it will cause a segfault.
I recently sent a similar fix which forbids deleting non-netdev net
clients from netdev_del:
http://patchwork.ozlabs.org/patch/193759/
Hi Stefan,
Sorry I did not see it... Seems I miss this chance to submit a patch. :-P
BTW, I was thinking that should we add another hacking to check
if the deleting object is a netdev or a VLAN client?
netdev_del should only be used on -netdev/netdev_add devices.
Therefore my patch raises an error before we call
qemu_del_net_client(nc).
Stefan
--
Lei
