Hi Eric, thank you for the review again. On 2012/11/13 7:16, Eric Blake wrote: > On 11/12/2012 02:32 AM, Tomoki Sekiyama wrote: >> Adds sample hook scripts for --fsfreeze-hook option of qemu-ga. >> - fsfreeze-hook : execute scripts in fsfreeze-hook.d/ >> - fsfreeze-hook.d.sample/mysql-flush.sh : quiesce MySQL before snapshot >> >> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama...@hitachi.com> >> --- > >> +LOGFILE=/var/log/qga-fsreeze-hook.log > > s/fsreeze/fsfreeze/
Oops... >> +# Iterate executables in directory "fsfreeze-hook.d" with the specified args >> +[ ! -d "$FSFREEZE_D" ] && exit 1 >> +for file in "$FSFREEZE_D"/* ; do >> + is_ignored_file "$file" && continue >> + [ -x "$file" ] || continue >> + echo $(date) ": execute $file $@" >>$LOGFILE > > Put $(date) inside the ""; otherwise, single-digit days will be one > character shorter due to IFS field splitting eating the double-space; > and I don't like unaligned dates in logs. > >> + "$file" "$@" >>$LOGFILE 2>&1 >> + STATUS=$? >> + echo $(date) ": $file finished with status=$STATUS" >>$LOGFILE > > and again. I will fix this. >> + INNODB_STATUS=$(mktemp /tmp/mysql-flush.XXXXXX) >> + [ $? -ne 0 ] && exit 2 >> + trap "rm -f $INNODB_STATUS" SIGINT >> + while :; do >> + echo 'SHOW ENGINE INNODB STATUS \G' | $MYSQL > $INNODB_STATUS > > 'echo' cannot portably be used with \. Use 'printf' instead. OK, I replace this with 'printf' (also in 'flush_and_wait' function). -- Tomoki Sekiyama <tomoki.sekiyama...@hitachi.com> Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory
