On 13.11.2012 18:30, Aurelien Jarno wrote: > Isn't ad0b5321f1f797274603ebbe20108b0750baee94 enough?
Oh. It has been applied. I expected it will be ignored just like my patch has been. No, it is not enough: that patch alone does nothing for the alignment on at least x86, which is necessary for hugepages to work. My patch _also_ fixes alignment issue. Where to apply MADV_HUGEPAGE is a different question. I don't know which layer it is best to apply it to. Thanks, /mjt > On Mon, Nov 12, 2012 at 07:18:49PM +0400, Michael Tokarev wrote: >> Ping^2 ? >> >> Thanks, >> >> /mjt >> >> 16.09.2012 15:19, Michael Tokarev wrote: >>> So, is the patch okay? >>> >>> Thanks, >>> >>> /mjt >>> >>> On 15.08.2012 19:03, Michael Tokarev wrote: >>>> On 15.08.2012 18:26, Avi Kivity wrote: >>>>> On 08/15/2012 05:22 PM, Michael Tokarev wrote: >>>>> >>>>>>> >>>>>>> Please provide extra info, like the setting of >>>>>>> /sys/kernel/mm/transparent_hugepage/enabled. >>>>>> >>>>>> That was it - sort of. Default value here is enabled=madvise. >>>>>> When setting it to always the effect finally started appearing, >>>>>> so it is actually working. >>>>>> >>>>>> But can't qemu set MADV_HUGEPAGE flag too, so it works automatically? >>>>> >>>>> It can and should. >>>> >>>> Something like the attached patch? >>>> >>>> Thanks, >>>> >>>> /mjt >>> >> >> >> >
