于 2012-11-16 18:16, Peter Maydell 写道:
On 16 November 2012 10:08, Wenchao Xia <xiaw...@linux.vnet.ibm.com> wrote:
于 2012-11-16 17:27, Peter Maydell 写道:
On 16 November 2012 05:05, Wenchao Xia <xiaw...@linux.vnet.ibm.com> wrote:
- test -f pixman/config.log && make -C pixman distclean
+ @if test -f pixman/config.log; \
+ then \
+ make -C pixman distclean;\
+ fi
These two bits of shellscript both do the same thing, don't they?
Looks the same, but on my machine
make -C pixman distclean
got executed resulting error, I guess that is what original author
wants to avoid.
If your shell executes Y in "X && Y" even if X fails, then your
shell is badly badly broken. More likely, there is some other
problem, and you need to find out what it is.
I don't think this patch should be applied, I'm afraid.
-- PMM
My shell is OK, I missed the error reporting source before,
in my test I think it is first part reporting error, that
is "test -f pixman/config.log" directly report error.
This patch would eliminate this error.
--
Best Regards
Wenchao Xia
