On Mon, Nov 19, 2012 at 01:00:56PM +0100, Alexander Graf wrote: > > On 19.11.2012, at 12:51, Gleb Natapov wrote: > > > On Mon, Nov 19, 2012 at 12:35:47PM +0100, Alexander Graf wrote: > >> > >> On 19.11.2012, at 12:33, Gleb Natapov wrote: > >> > >>> On Mon, Nov 19, 2012 at 11:22:48AM +0100, Alexander Graf wrote: > >>>> > >>>> On 16.11.2012, at 19:46, Kevin O'Connor wrote: > >>>> > >>>>> On Fri, Nov 16, 2012 at 01:02:18PM -0500, Gabriel L. Somlo wrote: > >>>>>> ping > >>>>>> > >>>>>> On Thu, Nov 08, 2012 at 12:35:17PM -0500, Gabriel L. Somlo wrote: > >>>>>>> Updated _CRS method for HPET, bringing it in line with the way it is > >>>>>>> presented on recent hardware (e.g. Dell Latitude D630, MacPro5,1, > >>>>>>> etc); > >>>>>>> Allows it to be detected and utilized from Mac OS X; Also tested OK on > >>>>>>> Linux (F16 64-bit install DVD) and Windows (Win7 64-bit install DVD). > >>>>>>> > >>>>>>> Signed-off-by: Gabriel Somlo <so...@cmu.edu> > >>>>> > >>>>> I'm okay with the patch. I'm looking to see an Ack from one of the > >>>>> kvm/qemu developers. (I saw Gerd was okay with the last version of > >>>>> the patch.) > >>>> > >>>> IIRC Marcelo was the one changing the DSDT code from what this patch > >>>> produces to what we have today. My initial HPET DSDT entry was also > >>>> copied from real hardware. > >>>> > >>>> Marcelo, any memory on this? :) Keep in mind I might be misremembering - > >>>> maybe it was someone else after all ;). > >>>> > >>> I think you are misremembering. Git shows that HPET entry was taken from > >>> pcbios code and my old pcbios git tree says that the dsdt code was > >>> contributed by Beth Kon and it is the same as we have it now in SeaBIOS. > >> > >> Hrm. I'm 100% sure that from my code (which Beth based on) to the code > >> that we have, someone had completely rewritten the DSDT entry. Either way, > >> not complaining as long as we get it sorted out eventually :). > >> > > Here is Beth's commit in bochs :) > > http://0x0badc0.de/gitweb?p=bochs/.git;a=commitdiff;h=874040e817e49811c30405d7c5d14b4c42161ca1;hp=1d2bac352688c75e8fdf8010f012b8ec85ba68d1 > > Ah, apparently Beth's DSDT bits were a rewrite done by Ryan. My original > version looked like this: > > http://lists.gnu.org/archive/html/qemu-devel/2008-01/msg00180.html > > but obviously broke quite a few things along the way ;). Also, I do remember > that I extracted the HPET bits from there and submitted them individually, > but I might really just be misremembering and it's not like that makes any > difference. > Just wanted to make sure that we do not revert someone's change without understanding why it was done in the first place. > > > > I added _STA logic in SeaBIOS but otherwise the code is the same. > > > >>> The patch looks OK. > >> > >> Mind to make this a formal acked-by? :) > >> > > Sure, will do. > > Just reply with the line ;) > Did it in a most formal way by answering to the patch itself :)
-- Gleb.