On 19 November 2012 13:14, Alexander Graf <ag...@suse.de> wrote: > > On 13.11.2012, at 13:11, Christian Borntraeger wrote: > >> From: Heinz Graalfs <graa...@linux.vnet.ibm.com> >> >> The global variable 'ram_size' is hidden by the local variable >> declaration in s390_init() > > That's the point of Eduardo's patch, no? Or do we need access > to the global to change its value afterwards?
The function later does: /* lets propagate the changed ram size into the global variable. */ ram_size = my_ram_size; which frankly I think is pretty nasty but then we've never had a very good mechanism for specifying board-specific restrictions around the memory size. -- PMM