Il 21/11/2012 10:19, Stefan Priebe - Profihost AG ha scritto: > Hello Stefan, > hello Paolo, > > most of the ideas and removing the whole cancellation stuff came from > Paolo. Maybe he can comment also?
I agree with all of Stefan's comments. This includes putting back acb->cancelled---but this time done right: note that qemu_rbd_complete_aio was always releasing the AIOCB if (acb->cancelled) { qemu_vfree(acb->bounce); qemu_aio_release(acb); goto done; } and according to Stefan's review it shouldn't. Paolo