On 23.11.2012, at 15:32, Christian Borntraeger wrote: > On 23/11/12 14:40, Alexander Graf wrote: >> >> On 23.11.2012, at 11:18, Jens Freimann wrote: >> >>> When resetting vcpus on s390/kvm we have to clear registers, psw >>> and prefix as described in the z/Architecture PoP, otherwise a >>> reboot won't work. IPL PSW and prefix are set later on by the >>> s390-ipl device reset code. >>> >>> Signed-off-by: Jens Freimann <jf...@linux.vnet.ibm.com> >>> --- >>> target-s390x/kvm.c | 26 +++++++++++++++++++++++++- >>> 1 file changed, 25 insertions(+), 1 deletion(-) >>> >>> diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c >>> index 94de764..b1b791e 100644 >>> --- a/target-s390x/kvm.c >>> +++ b/target-s390x/kvm.c >> >> This needs to go into generic vcpu reset code. > > The kvm ioctl certainly not, no? (definitely necessary for kernels > without sync regs).
Yes, of course :). > I guess you are talking about moving the register initialisation > into s390_cpu_reset (target-s390x/cpu.c). Right? Jens can you have > a look? Yup. This is just normal reset logic that needs to be in the normal CPU reset functions. Alex