On Sun, Nov 18, 2012 at 11:41:20AM +0100, Stefan Weil wrote: > Am 18.11.2012 09:55, schrieb Paolo Bonzini: > >Il 17/11/2012 17:40, Stefan Weil ha scritto: > >>backends/rng-random.c which was added by commit > >>5c74521d249486fa3e749dbbf6d56a70d4d7235f needs > >>macro O_NONBLOCK. > >> > >>The macro O_NONBLOCK is not defined for all hosts. > >>Adding a default definition fixes builds for MinGW. > >> > >>Signed-off-by: Stefan Weil<s...@weilnetz.de> > >>--- > >> > >>This is a build fix. Therefore I'd appreciate if it could be > >>committed soon. > > > >This would make things blocking when they were supposed to be > >nonblocking, so I'd prefer not including it. I thought Anthony had a > >fix too? > > > >Paolo > > Yes, my patch is only a quick fix to enable builds with MinGW again. > > Anthony's patch solves the same problem by omitting the code in > comiplations for non-POSIX builds. > > My primary goal was fixing the build, so any of these two patches > is fine for me. > > A backends/rng-random.c which compiles with MinGW would be even better, > but maybe that needs a little more time. /dev/random is available with > MinGW, so there is no basic problem doing this.
Anthony's rng POSIX build patch was merged, dropping this. Stefan
