On Fri, 30 Nov 2012 17:27:17 -0200 Eduardo Habkost <ehabk...@redhat.com> wrote:
> The core qdev code uses the reset handler list from vl.c, and > currently *-user has some hacks to make CPU reset work. > > This moves qemu_register_reset(), qemu_unregister_reset() and > qemu_devices_reset() to a new file, hw/reset.c, that can be used by qdev > and by *-user. > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > --- [...] > diff --git a/hw/reset.c b/hw/reset.c > new file mode 100644 > index 0000000..5e34b80 > --- /dev/null > +++ b/hw/reset.c > @@ -0,0 +1,43 @@ > +#include "hw/reset.h" > +#include "qlist.h" missing #include <glib.h> for g_malloc/g_free [...] > diff --git a/xen-all.c b/xen-all.c > index 046cc2a..7d2a79f 100644 > --- a/xen-all.c > +++ b/xen-all.c > @@ -14,6 +14,7 @@ > #include "hw/pc.h" > #include "hw/xen_common.h" > #include "hw/xen_backend.h" > +#include "hw/reset.h" > #include "qmp-commands.h" > > #include "range.h" > -- > 1.7.11.7 > > Since you are going not include reset.o in *-user: although dedicated reset.c is nice to have perhaps you can drop reset.c /it's not very related to this series topic/ altogether to minimize scope of review and limit patch only to reset.h and qemu_register_reset(), qemu_unregister_reset() and qemu_devices_reset() stubs for *-user. -- Regards, Igor