On 6 December 2012 09:27, li guang <lig.f...@cn.fujitsu.com> wrote: > 在 2012-12-06四的 09:23 +0000，Peter Maydell写道： >> I mean that in the comments on the previous version of this >> patchseet we explained that this check is specifically checking >> for whether the breakpoint is enabled locally, and that your >> change to just returning bool broke this. And in this version >> of the patch there is still exactly the same problem. > > why broke? > this function just ask if breakpoint 'i' was enable, > so we answer enabled or not? 2 simple cases, any problem?
See what we said last time around: http://lists.nongnu.org/archive/html/qemu-devel/2012-12/msg00456.html Most of the callers to hw_breakpoint_enabled() are only asking "is this enabled at all?". This callsite is asking "is this breakpoint enabled as a local breakpoint and only as a local breakpoint?". -- PMM
