On Sat, Dec 8, 2012 at 10:59 AM, Andreas Färber <afaer...@suse.de> wrote: > Generally we encourage people to upstream their devices, given they are > sufficiently isolated and/or maintainable.
Yes, that makes sense and have been doing that. We maintain an upstream repo, but needed to merge with a more recent qemu release for some critical updates and many api's changed from where we were. Merging was just a small matter of coding, but I thought it might be easier to keep up with the latest and greatest if it was part of it, if that's ok to do. Not a big deal if not. This patch is a side project I did on my own time for fun and learning. > IIUC from the website above, NVMe is to be used with SSDs? It would be > good to add to the commit message how to actually use the device > command-line-wise beyond the obvious -device nvme: I did not spot on > brief sight where you expose a bus to add drives (nor a special IF_* > interface type to assign to a drive), so others might wonder as well. Actually the nvme device _is_ the SSD. The emulated controller here creates files to use for its backing storage so you don't add additional drives, if that makes sense. Thanks for all the info; this is a good learning experience for me.
