On 12/10/2012 07:37 AM, Stefan Weil wrote:
Am 10.12.2012 07:16, schrieb John Spencer:
Your patch is not shown here because you had attached it to your email.
Please use "git send-email" to send patches.See also
http://wiki.qemu.org/Contribute/SubmitAPatch.
thanks, resent with git send-email.
i hope it is ok now.
In your patch, you replaced a wrong forward declarationof function
setgroups
by an include statement using grp.h. That's fine.
Reviewed-by: Stefan Weil <s...@weilnetz.de>
There are more extern declarations in linux-user/syscall.c.
Even if they are correct, they should be replaced by include statements.
If there will be a v2 of your patch series, you could add patches
for those declarations, too.
ok, will do separately after this first batch is merged.
Regards,
John Spencer
