On Sat, Dec 08, 2012 at 07:02:39PM +0100, Andreas Färber wrote: > Am 08.12.2012 18:54, schrieb Blue Swirl: > > Thanks, applied. > > As discussed this still leaves some cpudef cruft behind. > > Eduardo, can you please send a follow-up to move the versioning code and > kills all cpudef_*(), now that the patch got prematurely applied?
Discussions about process aside, I don't see the relation between removing the entry for the "cpudef" config section from qemu-option.c (that's basically an unused variable, as no code used the config section since QEMU 1.2), and kiling the cpudef_*() functions (that aside from being named "cpudef_*", have nothing to do with the cpudef config section). Both cleanups are completely independent from each other. -- Eduardo