于 2012-12-11 7:53, Eduardo Habkost 写道:
On Tue, Dec 11, 2012 at 12:12:23AM +0100, Andreas Färber wrote:
Am 10.12.2012 19:09, schrieb Eduardo Habkost:
On Sun, Dec 09, 2012 at 08:45:52PM +0100, Andreas Färber wrote:
Commit 511c68d3af626cb0a39034cb77e7ac64d3a26c0c (finally kill cpudef
config section support) removed the cpudef parsing support but left
cpudef_* hooks behind. Remove those.
The cpudef_* functions have nothing to do with the cpudef config section
since QEMU 1.2, it is just about initializing CPU-definition-related
data structures, so the patch subject is a bit misleading.
My memory tells me they were specifically added for the config file
support... git-blame proves me wrong and shows they were added by Johan
Cooper and refactored by Blue, explaining his sudden cpudef patch
involvement. Sorry.
Do you have a proposal for a better text? My reasoning is we should
clean up before we forget about it and things stay behind.
Something like "kill the cpudef_setup() hook that we don't need anymore
[because only x86 uses it, and we can simply use class_init to
initialize data structures]" sounds good enough to me.
Hi, Eduardo
I think we need uninstall rules which should delete the def files,
otherwise we met error:
qemu-system-x86_64:/usr/local/etc/qemu/target-x86_64.conf:3: There is no
option group 'cpudef'
--
Best Regards
Wenchao Xia
