Il 12/12/2012 15:30, Michael S. Tsirkin ha scritto: > > Same for virtio-scsi. Each request in that case is sent as part of the > > SCSIDevice that it refers to, via callbacks in SCSIBusInfo.
It is in virtio_scsi_load_request. > Looks like this will leak ring entries. > > All I see is: virtio_scsi_load calling virtio_load. > When the loading side will get last avail index it > will assume all requests up to that value have > completed, so it will never put the missing heads > in the used ring. Ok, so we need some API for virtio-{blk,scsi} to communicate back the indexes of in-flight requests to virtio. The indexes are known from the VirtQueueElement, so that's fine. Even better would be a virtio_save_request/virtio_load_request API... Paolo