On Dec 7, 2007, at 3:20 PM, Bernhard Kauer wrote:
On Fri, Dec 07, 2007 at 02:10:35PM +0100, Alexander Graf wrote:
Could you please make this more readable?
Not easy by a one liner. I splitted the mask calculation in a
separate line.
Is it better now?
Much better, yes.
Apart from that the patch is fine if the highest bit in the IOIO
vector is
to be set. I could not find that in the documentation.
I did not understand your comment. Perhaps you mean the following
sentence from the AMD vol. 2:
I actually misread your patch, nevermind.
For IN/OUT instructions that access more than a single byte, the
permission bits for all bytes are checked; if any bit is set to 1,
the I/O operation is intercepted.
That was the one. Thank you.
Greetings,
Bernhard
<qemu_ioio.diff>
Looks good now (apart from whitespaces).
Signed-off-by: Alexander Graf <[EMAIL PROTECTED]>
Cheers,
Alex
