Hi,

>> If you send me a fix for 6e72719e721a40fe1224701ca10edc1caf0cd708
>> I'll go revert 288fa40736e6eb63132d01aa6dc21ee831b796ae
> 
> 6e72719 is perfectly sane, because it brings consistency into the
> file. Now both users of PIXMAN_TYPE_BGRA are guarded by the same
> #ifdef.

Both users?  Hello?  Its two *different* types: PIXMAN_TYPE_RGBA and
PIXMAN_TYPE_BGRA.  And, yes, they have been added in different versions.
 So guarding them with the *same* #ifdef is wrong.

> #ifdef PIXMAN_TYPE_BGRA

It's a enum, not a #define, so this isn't going to fly.

cheers,
  Gerd


Reply via email to