> > I don't really see any conflicts here? > > query-balloon resets all stats to -1. So, if it's issued after the stats have > been > polled all values are lost.
I can't see that in the code. I also tested with my patch, and it does not reset any stats. So I can't see that conflict? There is no code to reset stats inside virtio_balloon_stat() > > > It's important to note that the QMP and HMP interfaces are also > > > dropped by this commit. That shouldn't be a problem though, because: > > > > > > 1. All QMP fields are optional > > > 2. This has never been really used > > > > Why don't we simply implement the missing parts - it's just a few lines of > code. > > For the reasons explained in my last email. We'd need at least two > commands, one for to enable polling/set time interval and also query- > balloon-stats, as adding this to query-balloon would mix semantics (ie. one > field is always there and the others have polling semantics). Yes, we need 2 commands - and what is the problem?
