Re: [Qemu-devel] [PATCH 3/6] snapshot: design of common API to take snapshots

[Wenchao Xia]

于 2012-12-22 2:49, Juan Quintela 写道:
> Wenchao Xia <xiaw...@linux.vnet.ibm.com> wrote:
>> +
>> +typedef struct SNTime {
>> +    uint32_t date_sec; /* UTC date of the snapshot */
>> +    uint32_t date_nsec;
> 
> This two fields are just struct timespec, does it makes sense to use it?
> 
  make sense, I did not notice timespec before, will use it if windows
support timespec too.


>> +
>> +/* Core structure for group snapshots, fill in it and then call the API. */
>> +typedef struct BlkTransactionStates BlkTransactionStates;
>> +
>> +struct BlkTransactionStates {
>> +    /* caller input */
>> +    bool async;
> 
> Why do we have this variable?  As far as I can see, we only test its
> value, and set it to false.  Are we missing any patch?
> 
  No, I just put it here as a reserved option. Maybe live block commit
can be considered as async deletion of snapshot, but nevermind I'll
delete it for that it is not supported now.



-- 
Best Regards

Wenchao Xia