On Wed, Jan 02, 2013 at 02:48:00PM +0100, Andreas Färber wrote: > Am 14.12.2012 18:21, schrieb Eduardo Habkost: > > On Fri, Dec 14, 2012 at 04:34:29PM +0100, Andreas Färber wrote: > >> Waiting for ack or nack from Paolo here. I am expecting some overlap > >> with his header file reorganization series. > >> > >> My previous (unanswered?) question was why you are moving vl.o lines in > >> addition to the QEMU_CFLAGS lines that you mention in the commit message. > > > > > > I thought this note in the commit message would answer the question: > > > >>> This also moves the existing CFLAGS lines from Makefile.objs at the > >>> beginning of the file, to keep them all in the same place. > > > > In other words: it's cosmetic, just to keep all the QEMU_CLFAGS lines > > inside Makefile.objs grouped in a visible place at the beginning of the > > file. > > > > (You noticed that I am moving the vl.o lines _inside_ Makefile.obj, > > right? They are not being moved between different files.) > > Nah, you caught me there, must've misread that on a previous submission > (or it changed or whatever). > > Anyway, Paolo's header reorganization was pulled by now, so this patch > no longer seems necessary, series compiles without. Please shout if I'm > misreading this!
Correct, commit 9d9199a003 from Paolo makes this patch unnecessary. -- Eduardo
