On 03.01.2013, at 18:28, Peter Maydell wrote: > On 3 January 2013 14:45, Alexander Graf <ag...@suse.de> wrote: >> >> On 02.01.2013, at 21:53, Samuel Seay wrote: >> >>> Removed h2g() macro around the ka->_sa_handler due to the _sa_handler being >>> a guest memory address >>> Changed the __put_user to put_user as it was attempting to put a value at >>> the stack address but the new address is a guest memory address, __put_user >>> is for host memory addresses. >>> Patch v2 -> v3, removed unneeded casting in the put_user call left over >>> from __put_user >>> >>> Signed-off-by: Samuel Seay <lightnin...@gmail.com> >> >> Looks reasonable to me, but I'd like an ack from Peter. > > Untested, and I haven't looked up the PPC ABI to check that the > function is overall doing the right thing, but with those caveats: > Reviewed-by: Peter Maydell <peter.mayd...@linaro.org>
Considering the state it was in before, I'd say applying the patch is an improvement regardless on how broken any code around it might be :). Applied to ppc-next. Alex
