Re: [Qemu-devel] [PATCH] linux-user/syscall.c: fix copy_to_user_fdset for fds over 30

[Richard Henderson]

On 01/03/2013 02:02 AM, Nickolai Zeldovich wrote:
> -            v |= ((FD_ISSET(k, fds) != 0) << j);
> +            v |= (((abi_ulong) (FD_ISSET(k, fds) != 0)) << j);

It would be easier to read if you dropped the unnecessary parens.

        v |= (abi_ulong)(FD_ISSET(k, fds) != 0) << j;

Otherwise the change looks correct.


r~