On Tue, Jan 8, 2013 at 9:03 AM, Stefan Hajnoczi <stefa...@gmail.com> wrote: > On Mon, Jan 07, 2013 at 03:38:39PM -0500, Nickolai Zeldovich wrote: >> memcpy() for overlapping regions is undefined behavior; use memmove() >> instead in readline_hist_add(). >> >> Signed-off-by: Nickolai Zeldovich <nicko...@csail.mit.edu> >> --- >> readline.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > I made a slight modification: keep the tab characters since the > surrounding code still uses them.
I think tabs should be fixed whenever possible, otherwise we may never get them converted. > > Thanks, applied to the trivial patches tree: > https://github.com/stefanha/qemu/commits/trivial-patches > > Stefan >