On 01/16/2013 08:24 AM, Eduardo Habkost wrote: > Without this check, QEMU will corrupt memory if a too-large nodeid is > provided in the command-line. e.g.: > > -numa node,mem=...,cpus=...,nodeid=65 > > This changes nodenr to unsigned long long, to avoid integer conversion > issues when converting the strtoull() result to int. > > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > --- > Changes v2: > - Implement change without creation of numa_node_add() function
> > + if (nodenr >= MAX_NODES) { > + fprintf(stderr, "qemu: invalid NUMA nodeid: %d\n", nodenr); %lld (I see you later fixed that in 6/8, but you should rebase that hunk into the patch that first needs it). -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature