17.01.2013 17:06, Stefan Hajnoczi wrote:
On Thu, Jan 17, 2013 at 02:44:41PM +0400, Michael Tokarev wrote:
We have iov_from_buf() and iov_to_buf(), use them instead of
open-coding these in block/win32-aio.c

Please use qemu_iovec_from_buf() and qemu_iovec_to_buf() since we're
operating on a QEMUIOVector.

I'd remove qemu_iovec_{from,to}_buf() completely at this point
due to their trivialness and almost no gain in usage as polluting
the namespace (having too many trivial utility functions isn't
good).  Right now these are only used in one place - in
hw/dataplane/virtio-blk.c .

If not, we can at least inline them.

Thanks,

/mjt

Reply via email to