On Fri, Jan 18, 2013 at 3:36 PM, Markus Armbruster <arm...@redhat.com> wrote: > Blue Swirl <blauwir...@gmail.com> writes: > >> On Mon, Jan 14, 2013 at 7:01 PM, Markus Armbruster <arm...@redhat.com> wrote: >>> [Thread hijack, dropping cc: qemu-trivial, qemu-ppc] >>> >>> Andreas Färber <afaer...@suse.de> writes: >>> >>>> Am 14.01.2013 13:19, schrieb Markus Armbruster: >>>>> Andreas Färber <afaer...@suse.de> writes: >>> [...] >>>>>> diff --git a/qom/object.c b/qom/object.c >>>>>> index 351b88c..03e6f24 100644 >>>>>> --- a/qom/object.c >>>>>> +++ b/qom/object.c >>>>>> @@ -1017,7 +1017,7 @@ gchar *object_get_canonical_path(Object *obj) >>>>>> return newpath; >>>>>> } >>>>>> >>>>>> -Object *object_resolve_path_component(Object *parent, gchar *part) >>>>>> +Object *object_resolve_path_component(Object *parent, const gchar *part) >>>>>> { >>>>>> ObjectProperty *prop = object_property_find(parent, part, NULL); >>>>>> if (prop == NULL) { >>>>> >>>>> Unrelated: do we really want to go along with glib's basic type typedef >>>>> silliness? >>>> >>>> Elsewhere I have adopted the exact GLib signature since typedefs can be >>>> changed at any time. In particular the GCompareFunc using gconstpointer, >>>> gint, etc. Not saying I find their GLib usage useful. >>> >>> No, these typedefs cannot be changed. >>> >>> Firstly, their exact definitions are documented[*], therefore can be >>> relied on. >>> >>> Secondly, mountains of code rely on the exact definitions, and would >>> break left and right if they were changed. >>> >>> They're a textbook example of a perfectly useless pseudo-abstraction. >> >> CONST, WORD, PWORD, DWORD, FLOAT etc. in a certain platform... > > MY EYES, MY EYES, WHAT DID YOU DO TO MY EYES!!!
Leishmaniasis Capslockititis Fenestrae? :-D > > [...]