19.01.2013 18:58, Michael Tokarev wrote:
Now, if seccomp is detected, it is linked into every executable, but is used only by softmmu targets (from vl.c). So link it only where it is actually needed.
Note this is not just a cleanup. For some reason, at least debian package of seccomp lacks static library (this needs separate investigation and maybe a fix), so when building linux-user-static targets the build fails, since libseccomp is linked into static linux-user executables. So consider it is a bugfix. Note that Makefile.objs adds qemu-seccomp.o to common-objs-y, -- maybe this whole variable (common-objs) should be renamed to softmmu-objs, to match other softmmu-* stuff? But I'm not sure I understand this makefile machinery. /mjt